Add pretty formatting for types #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
reviewed
Jan 6, 2021
|
It's true, the name format thing is a bit weird. |
|
@trelau if you have any thoughts about this your input is welcome |
|
Coming back to this, I still don't think this is the right fit. In particular, there are several elements that one could format in one of several different ways depending on what you wanted. |
virtuald
force-pushed
the
fmt-types
branch
3 times, most recently
from
8bd749e to
5e16f16
Compare
virtuald
force-pushed
the
fmt-types
branch
2 times, most recently
from
9d22018 to
4dc64b5
Compare
|
Changed to |
virtuald
commented
Sep 30, 2023
virtuald
force-pushed
the
fmt-types
branch
2 times, most recently
from
6b78c5e to
f988ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like it, but is it too clever? Open to suggestions.
Normal string formatting converts to the canonical expected representation, but if you want to make a declaration then you need to either call
__format__directly, or you can pass a format spec with the name in it (f"{type:name}").